fix(lint): add golangci-lint make target + lint #193
Conversation
| const ( | ||
| CustomAuthorizationHeader = "kubernetes-authorization" | ||
| OAuthAuthorizationHeader = "Authorization" | ||
| CustomAuthorizationHeader = HeaderKey("kubernetes-authorization") |
There was a problem hiding this comment.
Not sure why linter forces us to do this
There was a problem hiding this comment.
The problem is not at the header level, but at the usage within context.WithValue:
This was the first thing I thought of to solve it.
|
Maybe it is better to define set of linters like openshift/lws-operator@1f2f698#diff-9917ddc9f1c3304218f7269265b746d997c5c0615478177b5fceecd33ef47cb5. Not a blocker for this PR though |
Whatever you think is more suitable, I added the linter because you suggested it. Once this is in, we should also enable the linter on the CI, we an define the set in the follow-up too. |
Thank you. That looks good to me. |
Signed-off-by: Marc Nuri <[email protected]>
/cc @ardaguclu